fix(memory): empty memory case - #6322
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview The no-match branch now routes through The get-by-id API contract now types Reviewed by Cursor Bugbot for commit 47e9298. Configure here. |
Greptile SummaryThis PR fixes empty Memory lookups by routing them through the existing provenance-aware response helper and updates the API contract to permit the established null result.
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness or security issues identified. The empty-result path now produces the metadata envelope required by internal tools, ordinary callers retain their prior response, and the contract accurately accepts the route’s null result.
|
| Filename | Overview |
|---|---|
| apps/sim/app/api/memory/[id]/route.ts | Routes empty lookup results through the provenance response helper while retaining the existing null payload for requests that do not negotiate metadata. |
| apps/sim/lib/api/contracts/memory.ts | Makes the successful GET response schema nullable so contract validation matches the route’s established not-found response. |
| apps/sim/app/api/memory/[id]/route.test.ts | Covers exact-empty provenance metadata and confirms that ordinary callers retain the headerless null response. |
Reviews (1): Last reviewed commit: "fix(memory): provenance checks" | Re-trigger Greptile
Summary
Fixes Memory blocks failing with: Internal tool response metadata could not be verified when Get Memory looks up a conversation that does not yet exist.
Type of Change
Testing
Tested manually
Checklist